Well, I for one really enjoy spending my money on nice things for my favorite hobby. My Elite Controller and Astro Headset are extremely beneficial to me. I have the income to spend on these things and I enjoy them thoroughly and do not regret them at all. The extra paddles and abundance of customization options (trigger/stick sensitivities and profiles, button remapping, controller profiles, etc.) on the Elite controller are amazing and benefit those who know how to utilize them appropriately. I noticed a HUGE improvement in my gaming within FPS games like Overwatch and GTA. The optional hairpin trigger has been a huge increase on getting the one-up on others drawing or shooting. I also love all the extra buttons for survival games like The Forest and ARK.
As far as my Astros, they were necessary to improve the quality of my stream. I do a lot of RP and talking in general so I wanted a good pair of astros with an A+ mic too which was a vast improvement even in comparison to my Turtle Beaches. They were well worth the upgrade and made a surprising improvement in my audio quality.
On top of all this I am usually always saving money to make my setup look eye-appealing as well. Lighting, storage, etc.
If you have the money to buy nice things and it makes you happy, do it.